-
Notifications
You must be signed in to change notification settings - Fork 3
chore: update dependencies and improve workflow configurations #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Bump azd version to 1.20.0 in devcontainer.json - Update checkout and setup actions in azure-dev.yml - Add Node.js setup step in terraform-validate.yml - Adjust target framework indentation in Directory.Build.props and CopilotTests.csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the development environment and CI/CD workflows by upgrading key tool versions and improving compatibility for self-hosted runners. The changes focus on ensuring the project uses current versions of essential development tools while maintaining stability and security.
Key changes:
- Upgraded Azure Developer CLI from 1.18.1 to 1.20.0 in the development container
- Updated Terraform version from 1.12.2 to 1.13.3 in CI workflows
- Replaced .NET SDK setup action with manual installation script targeting .NET 9.0 for better self-hosted runner compatibility
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/terraform-validate.yml |
Added Node.js 18.x setup and updated Terraform version to 1.13.3 |
.github/workflows/azure-dev.yml |
Replaced .NET SDK action with manual installation script for .NET 9.0 |
.devcontainer/devcontainer.json |
Updated Azure Developer CLI version to 1.20.0 and improved extension comments |
Co-authored-by: Matt Dotson <[email protected]>
Co-authored-by: Matt Dotson <[email protected]>
ianjensenisme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting issue but shouldn't block build/merge
This pull request updates development environment configurations and CI workflows to use newer versions of key tools and improves compatibility for self-hosted runners. The most important changes include upgrading the .NET SDK and Azure Developer CLI versions, updating the Terraform version, and adding Node.js setup in CI.
Development environment upgrades:
.devcontainer/devcontainer.jsonfrom1.18.1to1.20.0for improved features and compatibility.CI workflow improvements:
.github/workflows/azure-dev.ymlto use a manual installation script targeting .NET 9.0, improving compatibility with self-hosted runners and avoiding permission issues..github/workflows/terraform-validate.ymlfrom1.12.2to1.13.3for better support and security.18.x) in the Terraform validation workflow to support Node-based tooling.Minor documentation update:
.devcontainer/devcontainer.jsonfor guidance on adding VSCode extensions.