Skip to content

Enhance person directory notebook by initializing persons list #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2025
Merged

Enhance person directory notebook by initializing persons list #78

merged 5 commits into from
Sep 23, 2025

Conversation

changjian-wang
Copy link
Contributor

…dating face association logic

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: Improve the build person directory feature.

@changjian-wang changjian-wang changed the title Enhance person directory notebook by initializing persons list and up… Enhance person directory notebook by initializing persons list Aug 11, 2025
@changjian-wang changjian-wang self-assigned this Aug 11, 2025
@changjian-wang changjian-wang mentioned this pull request Aug 11, 2025
Open
chienyuanchang
chienyuanchang requested changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@chienyuanchang chienyuanchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @changjian-wang, Yung-Shin mentioned that we will need to update this notebook first. I found a blocking issue to make the notebook failed.

@changjian-wang changjian-wang merged commit be72448 into main Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chienyuanchang chienyuanchang chienyuanchang approved these changes

@yungshinlintw yungshinlintw Awaiting requested review from yungshinlintw

Assignees

@changjian-wang changjian-wang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@changjian-wang @chienyuanchang