Skip to content

Conversation

@Pavan-Microsoft
Copy link
Contributor

Purpose

This pull request introduces a consistent approach to passing the managed identity client ID to the get_azure_credential function throughout the codebase. This change improves security and flexibility by ensuring that Azure service clients use the correct identity for authentication, especially in environments configured for RBAC. Additionally, environment variable handling and secret management are enhanced for better reliability and key vault usage.

Authentication and Credential Management:

  • Updated all calls to get_azure_credential to pass MANAGED_IDENTITY_CLIENT_ID from environment variables, ensuring proper managed identity authentication for Azure services [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18].
  • Added MANAGED_IDENTITY_CLIENT_ID to the EnvHelper class, loading it from environment variables for centralized access.

Secret and Key Vault Handling:

  • Improved secret retrieval by always using Key Vault for FUNCTION_KEY when available, and added a check to ensure AZURE_KEY_VAULT_ENDPOINT is set when Key Vault is enabled [1] [2] [3].

Configuration and Dependency Injection:

  • Updated Azure token provider setup in EnvHelper to use the managed identity client ID for acquiring tokens.
  • Injected EnvHelper into PostgresConversationClient for easier access to environment configuration [1] [2].

Minor and Cosmetic Changes:

  • Commented out the metadata section in azure.yaml for clarity or future use.

These changes collectively strengthen the application's authentication mechanisms and improve maintainability by centralizing environment and credential management.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the deployment and application end to end testing.

Roopan-Microsoft and others added 30 commits November 25, 2024 16:02
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Ross Smith <[email protected]>
Co-authored-by: gpickett <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Prajwal D C <[email protected]>
…nd Update Conversation flow based on template selection (Azure-Samples#1567)

Co-authored-by: Pavan Kumar <v-kupavan.microsoft.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavan-Microsoft <[email protected]>
Pavan-Microsoft and others added 20 commits September 10, 2025 23:32
…vices module and include resource group and subscription ID in web app settings
…os SQL role assignments, App Service settings, App Service plans, ACR access permissions, role assignments, custom types for private networking, and private DNS zone configurations to streamline the infrastructure codebase.
…tgreSQL module to enhance security and simplify configuration
@Prajwal-Microsoft Prajwal-Microsoft merged commit 5d561e9 into Azure-Samples:waf-avm Sep 15, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.