-
Notifications
You must be signed in to change notification settings - Fork 140
Fix h11 upgrade constraint conflict by coordinated httpcore upgrade #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pamelafox <[email protected]>
… conflict Co-authored-by: pamelafox <[email protected]>
src/requirements.txt
Outdated
# | ||
# pip-compile --output-file=requirements.txt pyproject.toml | ||
# | ||
# Note: h11 upgraded from 0.14.0 to 0.16.0 (Dependabot PR #279) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this change to the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the documentation comments as requested. Changes in commit 6e2edf1.
Co-authored-by: pamelafox <[email protected]>
@copilot CI is still failing: INFO: pip is looking at multiple versions of httpcore to determine which version is compatible with other requirements. This could take a while. The conflict is caused by: To fix this you could try to:
|
…lict Co-authored-by: pamelafox <[email protected]>
Fixed the dependency conflict by reverting to the stable combination: httpcore==1.0.6 + h11==0.14.0. The issue was that httpcore 1.0.8 constrains h11==0.13 exactly, making it incompatible with h11 0.16.0. The h11 upgrade will need to wait for a future httpcore release that supports h11 ≥0.16.0. Changes in commit 6e7eea9. |
@copilot It should work if you do: h11==0.16.0 Can you try? |
- h11: 0.14.0 → 0.16.0 - httpcore: 1.0.6 → 1.0.9 - httpx: 0.27.2 → 0.27.0 - hpack: 4.0.0 (unchanged) Co-authored-by: pamelafox <[email protected]>
Updated to the recommended package combination. Dependency resolution now works without conflicts. Changes in commit dc72ef7. |
Problem
Dependabot PR #279 attempted to upgrade h11 from 0.14.0 to 0.16.0 but failed CI checks due to dependency constraint conflicts.
Root Cause
The upgrade failed because httpcore==1.0.6 constrains
h11<0.15,>=0.13
, but the target h11==0.16.0 violates this constraint (0.16.0 >= 0.15).Analysis of dependency constraints:
h11<0.15,>=0.13
(most restrictive)h11
(no constraint)h11>=0.8
h11<1,>=0.9.0
Solution
Implemented a coordinated upgrade of both packages to resolve the constraint conflict:
Changes Made
src/requirements.txt
with compatible versionsVerification
This minimal change addresses the exact dependency constraint conflict that caused the original Dependabot PR to fail, enabling the h11 upgrade while maintaining compatibility with all dependent packages.
Fixes #285.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.