Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 24, 2025

This PR simplifies the Azure deployment workflow by removing conditional logic from the authentication steps and consolidating to a single login method using Federated Credentials.

Changes Made

Before:

  • Two conditional login steps:
    • Log in with Azure (Federated Credentials) with if: ${{ env.AZURE_CLIENT_ID != '' }}
    • Log in with Azure (Client Credentials) with if: ${{ env.AZURE_CREDENTIALS != '' }}

After:

  • Single unconditional login step using Federated Credentials:
- name: Log in with Azure (Federated Credentials)
  run: |
    azd auth login `
      --client-id "$Env:AZURE_CLIENT_ID" `
      --federated-credential-provider "github" `
      --tenant-id "$Env:AZURE_TENANT_ID"
  shell: pwsh

Benefits

  • Simplified workflow logic: Eliminates conditional authentication branching
  • Reduced complexity: Removes potential failure points from dual authentication paths
  • Consistent authentication: Uses only Federated Credentials (current best practice)
  • Follows GitHub Actions best practices: Aligns with recommended patterns for Azure authentication

Impact

  • Minimal change: 0 lines added, 15 lines removed
  • No functional impact on successful deployments using Federated Credentials
  • YAML syntax validated and confirmed working

Fixes #296.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Remove conditional from Azure login step in deployment workflow Remove conditional from Azure login step in deployment workflow Jul 24, 2025
@Copilot Copilot AI requested a review from pamelafox July 24, 2025 20:21
Copilot finished work on behalf of pamelafox July 24, 2025 20:21
@pamelafox pamelafox marked this pull request as ready for review July 25, 2025 05:49
@pamelafox pamelafox merged commit 58780a9 into main Jul 25, 2025
3 checks passed
@pamelafox pamelafox deleted the copilot/fix-296 branch July 25, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove conditional from Azure login step in deployment workflow
2 participants