Improve runDiagnostics debug output when no resource info available#210
Merged
stevekuznetsov merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
stevekuznetsov
approved these changes
Mar 2, 2026
203ab92 to
d882062
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves the runDiagnostics debug output in tools/helm/options.go by adding diagnostic logging and a Kusto namespace query when no resource info is available in a Helm release (i.e., when release.Info == nil or release.Info.Resources is empty). Previously, the function would silently return nil in that case. It also moves the deploymentStart/deploymentEnd variable declarations to the top of the function so they are available before the early-exit path.
Changes:
- Moves
deploymentStartanddeploymentEndvariable declarations to the top ofrunDiagnostics, before the early-exit guard. - Adds a
logger.Infocall to log when no resource info is available (withinfoNilandresourceCountkey-value pairs). - Adds a Kusto namespace-level deep link query (
getNamespaceQuery) in the early-exit path to aid troubleshooting when no resource info is present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d882062 to
15a3788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added debugging info and namespace kusto query when no resource info available