fix: copy kubectl and kubelet to /usr/local/bin for compatibility #7804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewi
requested review from
AbelHu,
Devinwong,
YaoC,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright,
yewmsft and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds compatibility for copying kubectl and kubelet binaries to /usr/local/bin to support hardcoded paths in some AKS usage patterns. The change is implemented across multiple OS-specific installation scripts while attempting to preserve compatibility with immutable filesystems like Flatcar.
Changes:
- Adds copying of kubectl/kubelet to /usr/local/bin after package installation
- Implements conditional check for writable /usr/local/bin in common install script
- Updates snapshot test data to reflect binary changes in Flatcar and CustomizedImage scenarios
Reviewed changes
Copilot reviewed 34 out of 68 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/cse_install.sh | Adds conditional copy to /usr/local/bin with writability check [ -w /usr/local/bin ] |
| parts/linux/cloud-init/artifacts/ubuntu/cse_install_ubuntu.sh | Adds unconditional copy to /usr/local/bin - missing writability check |
| parts/linux/cloud-init/artifacts/mariner/cse_install_mariner.sh | Adds unconditional copy to /usr/local/bin - missing writability check |
| pkg/agent/testdata/Flatcar/CustomData.inner | Base64-encoded snapshot test data update |
| pkg/agent/testdata/Flatcar+CustomCloud/CustomData.inner | Base64-encoded snapshot test data update |
| pkg/agent/testdata/Flatcar+CustomCloud+USSec/CustomData.inner | Base64-encoded snapshot test data update |
| pkg/agent/testdata/CustomizedImageLinuxGuard/CustomData | Base64-encoded snapshot test data update |
| pkg/agent/testdata/CustomizedImage/CustomData | Base64-encoded snapshot test data update |
chewi
force-pushed
the
chewi/usr-local-bin-compat
branch
from
a7eb5cb to
45e6c80
Compare
Contributor
Author
|
The failures are unrelated. |
djsly
reviewed
Feb 6, 2026
Regrettably, some AKS usage is hardcoded to expect /usr/local/bin. We still want to avoid writing here on immutable distros, but we can retain compatibility in other cases. Signed-off-by: James Le Cuirot <[email protected]>
chewi
force-pushed
the
chewi/usr-local-bin-compat
branch
from
45e6c80 to
c255ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Regrettably, some AKS usage is hardcoded to expect /usr/local/bin. We still want to avoid writing here on immutable distros, but we can retain compatibility in other cases.
Which issue(s) this PR fixes:
Fixes a couple of Sev 2 IcMs.