Skip to content

Fix winrm listeners data type #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix winrm listeners data type #4388

wants to merge 1 commit into from

Conversation

coolhome
Copy link
Contributor

Description

winRM is passed to listeners, which is an array and not an object. I was not able to perform set-module on the virtual machine construct, that template is broken.

Pipeline references

Pipeline

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@coolhome coolhome requested a review from a team as a code owner December 19, 2023 19:26
@AlexanderSehr
Copy link
Contributor

Hey @coolhome,
the construct template definitely is. It's essentially just code we parked when initially migrating all modules from ARM to Bicep. In the future setup with AVM, it would be considered a pattern.
I think the reason we did not outright delete it was that it contains logic to generate x amount of VM names for the deploying person.

coolhome
coolhome commented Dec 19, 2023
View reviewed changes
constructs/Compute/virtualMachinesMultiple/main.bicep
@description('Optional. Specifies additional base-64 encoded XML formatted information that can be included in the Unattend.xml file, which is used by Windows Setup. - AdditionalUnattendContent object.')
param additionalUnattendContent array = []

@description('Optional. Specifies the Windows Remote Management listeners. This enables remote Windows PowerShell. - WinRMConfiguration object.')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want to mention that this looks like it meant to be a type WinRMConfiguration but in actuality its WinRMListener. Maybe the solution is to remove the listener mapping and allow users to pass the WinRMConfiguration type?

@AlexanderSehr
Copy link
Contributor

@rahalan, note this update may be relevant for the AVM VM PR. However, @coolhome could it be the encoding or something similar was changed? The files appears completely new which makes it very hard to sport what actually changed.

@coolhome
Copy link
Contributor Author

@AlexanderSehr yah I just noticed that as well. I have core.autocrlf=false and I think this is the root cause.

image
This is not really a solution but a way to see the differences without the newline issue.

Let me know if you want to re-create the PR. I am also happy with whatever.

@coolhome coolhome mentioned this pull request Dec 19, 2023
Merged
@coolhome
Copy link
Contributor Author

Closing since its now implemented in Azure/bicep-registry-modules#717 for AVM.

@coolhome coolhome closed this Dec 20, 2023
@coolhome coolhome deleted the vm-winrm-datatype branch December 20, 2023 17:12
@AlexanderSehr
Copy link
Contributor

Hey @coolhome, may I ask you to re-open the PR? I think for VMSS this is still very much relevant, isn't it? This module isn't migrated yet / started.

@coolhome coolhome restored the vm-winrm-datatype branch December 25, 2023 02:57
@coolhome coolhome reopened this Dec 25, 2023
@AlexanderSehr AlexanderSehr requested a review from rahalan January 8, 2024 13:50
@TheMarcosP
Copy link

h

@AlexanderSehr
Copy link
Contributor

Hey @rahlan, I take it it's save to say you don't have this on your radar these days.
Could you please check if the contribution is already implemented in the VM/VMSS module and if not ideally consider to add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahalan rahalan Awaiting requested review from rahalan

At least 1 approving review is required to merge this pull request.

Assignees

@coolhome coolhome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coolhome @AlexanderSehr @TheMarcosP