Update the dependency to pnpm style when azureSdkForJs is true
#3210
Conversation
MaryGao
changed the title
MaryGao
changed the title
azureSdkForJs is true
MaryGao
changed the title
azureSdkForJs is trueazureSdkForJs is true
|
@v-jiaodi Could you work with @wanlwanl to verify if the floating version dependencies could run successfully with pnpm commands? If yes, I think we don't need to upgrade emitter versions with @jeremymeng's migration pr. We could upgrade emitters after that separately. |
|
@MaryGao @v-jiaodi @wanlonghenry The first pnpm PR in js repo doesn't have the floating versions yet, just switching from rush to pnpm as mono repo tool. |
|
@jeremymeng Thanks for the clarification! What is the plan to switch to catalog or workspace versions? Any other follow-ups after pnpm migration? |
…nto remove-rush-dependency
…nto remove-rush-dependency
…nto remove-rush-dependency
…nto remove-rush-dependency
|
@jiaodi Could we focus on the dev part first https://github.com/Azure/azure-sdk-for-js/blob/f6e317aec3cc878925002e648712fd278ec2ea32/sdk/quota/arm-quota/package.json#L85-L99? |
The current status is just like this. |
v-jiaodi
requested review from
joheredi,
qiaozha and
MaryGao
as code owners
| useLegacyLro?: boolean; | ||
| flavor?: PackageFlavor; | ||
| //TODO should remove this after finish the release tool test | ||
| shouldUsePnpmDep?: boolean; |
There was a problem hiding this comment.
i remember automation has used this option, @skywing918 do we need any update there?
There was a problem hiding this comment.
shouldUsePnpmDep is not used in automation.
| "dependencies": { | ||
| "@azure/core-client": "^1.9.3", | ||
| "@azure/core-rest-pipeline": "^1.19.1", | ||
| "@azure/core-client": "^1.9.2", |
There was a problem hiding this comment.
is the version correctly? the same as rest diffs.
There was a problem hiding this comment.
This was an incorrect change. It has already been reverted.
| "dev-tool run build-test && dev-tool run test:vitest --browser" | ||
| ); | ||
| expect(packageFile.scripts).to.have.property("pack", "npm pack 2>&1"); | ||
| expect(packageFile.scripts).to.have.property("pack", "pnpm pack 2>&1"); |
There was a problem hiding this comment.
We need to use pnpm pack so that the workspace version and catalog version specifiers are replaced with real versions in the packaged package.json
fixes #3410
Update the dependencies to pnpm style when
azureSdkForJsis true for HLC/RLC and Modular.