[sample gen] fail to generate samples-dev as tcgc doesn't give the samples #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Offline confirmed with Chenjie, it should be a TCGC issue. @kazrael2119 Could you create an issue for them? |
|
@kazrael2119 please verify if the fix in tcgc works or not |
|
close as should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from this spec pr Azure/azure-rest-api-specs#35588
We found that it doesn't generate the samples. Then I debugged in our emitter, I found that this is because tcgc doesn't match the sample and operation, so we couldn't generate them.
but I don't know the root cause of the tcgc mismatch