Add dev tool dependencies back to individual packages #3523
+599
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per Pnpm recommendation. Related azure-sdk-for-js PR: - Azure/azure-sdk-for-js#36094
v-jiaodi
reviewed
Oct 10, 2025
|
|
||
| delete packageInfo.devDependencies["@microsoft/api-extractor"]; | ||
| delete packageInfo.devDependencies["rimraf"]; | ||
| delete packageInfo.devDependencies["mkdirp"]; |
There was a problem hiding this comment.
@jeremymeng Based on https://github.com/Azure/azure-sdk-for-js/pull/36094/files#diff-18ae0a0fab29a7db7aded913fd05f30a2c8f6c104fadae86c9d217091709794cR29, mkdirp should also be added here, right?
There was a problem hiding this comment.
Only a few packages actually need mkdirp so not adding to every package.
There was a problem hiding this comment.
We may remove mkdirp from the catalog because of that.
v-jiaodi
reviewed
Oct 10, 2025
packages/rlc-common/src/metadata/packageJson/buildAzureMonorepoPackage.ts
Outdated
Show resolved
Hide resolved
MaryGao
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per Pnpm recommendation. Related azure-sdk-for-js PR: