[EventHubs] Fix #31108 and #32073 Regex updated for az eventhubs commands with --namespace-name arguments
#32472
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
Copilot finished reviewing on behalf of
aupetit-ms
November 27, 2025 08:44
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes validation issues (#31108 and #32073) with the --namespace-name argument in EventHubs commands. The regex pattern was incorrectly enforcing a minimum length of 8 and maximum of 52, while the documented constraints specify a minimum of 6 and maximum of 50 characters.
Key Changes:
- Updated regex pattern from
^[a-zA-Z][a-zA-Z0-9-]{6,50}[a-zA-Z0-9]$to^[a-zA-Z][a-zA-Z0-9-]{4,48}[a-zA-Z0-9]$ - This aligns the pattern with the declared
min_length=6andmax_length=50constraints - Applied consistently across all 13 affected command files
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/nsp_configuration/_show.py |
Updated namespace name validation pattern for nsp-configuration show command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/nsp_configuration/_list.py |
Updated namespace name validation pattern for nsp-configuration list command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_wait.py |
Updated namespace name validation pattern for namespace wait command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_update.py |
Updated namespace name validation pattern for namespace update command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_show.py |
Updated namespace name validation pattern for namespace show command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_failover.py |
Updated namespace name validation pattern for namespace failover command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_delete.py |
Updated namespace name validation pattern for namespace delete command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/namespace/_create.py |
Updated namespace name validation pattern for namespace create command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/eventhub/_update.py |
Updated namespace name validation pattern for eventhub update command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/eventhub/_show.py |
Updated namespace name validation pattern for eventhub show command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/eventhub/_list.py |
Updated namespace name validation pattern for eventhub list command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/eventhub/_delete.py |
Updated namespace name validation pattern for eventhub delete command |
src/azure-cli/azure/cli/command_modules/eventhubs/aaz/latest/eventhubs/eventhub/_create.py |
Updated namespace name validation pattern for eventhub create command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az eventhubs eventhub createaz eventhubs eventhub deleteaz eventhubs eventhub listaz eventhubs eventhub showaz eventhubs eventhub updateaz eventhubs namespace createaz eventhubs namespace deleteaz eventhubs namespace failoveraz eventhubs namespace showaz eventhubs namespace updateaz eventhubs namespace waitaz eventhubs namespace nsp-configuration listaz eventhubs namespace nsp-configuration showDescription
2 issues have been reported (#31108 and #32073) regarding the argument
--namespace-name. This argument has a min length defined at 6 and max at 50. But the regular expression provided to the pattern property doesn't match the min and max lengths.For example with a
--namespace-namevalue with a length equals to 7:az eventhubs namespace nsp-configuration list --namespace-name abc1234InvalidArgumentValue: --namespace-name: Invalid format: 'abc1234' does not fully match regular expression pattern '^[a-zA-Z][a-zA-Z0-9-]{6,50}[a-zA-Z0-9]$'The current regular expression min length is 8 and max 52.
Before:
To fix it, I modified it to have at the end a min at 6 and max at 50.
After:
Testing Guide
There are 3 tests to perform:
--namespace-namevalue length less than 6.--namespace-namevalue length equals to 6.--namespace-namevalue length more than 6.Before fix, with a
--namespace-namevalue length equals to 6:az eventhubs eventhub list --namespace-name abc123InvalidArgumentValue: --namespace-name: Invalid format: 'abc123' does not fully match regular expression pattern '^[a-zA-Z][a-zA-Z0-9-]{6,50}[a-zA-Z0-9]$'After fix, with a
--namespace-namevalue length equals to 6 (message expected because this resource doesn't exist):az eventhubs eventhub list --namespace-name abc123(ParentResourceNotFound) Failed to perform 'read' on resource(s) of type 'namespaces/eventhubs', because the parent resource '/subscriptions/.../resourceGroups/.../providers/Microsoft.EventHub/namespaces/abc123' could not be found. Code: ParentResourceNotFound Message: Failed to perform 'read' on resource(s) of type 'namespaces/eventhubs', because the parent resource '/subscriptions/.../resourceGroups/.../providers/Microsoft.EventHub/namespaces/abc123' could not be found.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.