-
Notifications
You must be signed in to change notification settings - Fork 14
Make set_hostname function available to libazureinit consumers #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cadejacobson
wants to merge
18
commits into
Azure:main
Choose a base branch
from
cadejacobson:cade/add-hostname
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpryan99
approved these changes
Oct 20, 2025
cjp256
reviewed
Oct 20, 2025
cjp256
reviewed
Oct 20, 2025
cea53d7 to
2589e8f
Compare
peytonr18
approved these changes
Oct 29, 2025
peytonr18
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the set_hostname function to the the libazureinit package for third party consumption by projects that add the libazureinit crate. This PR also adds tests that specifically cover the expected behavior of the
set_hostnamefunction.How to use
No difference in usage.
Testing done
This PR has been tested with the testinit process in the CI/CD pipeline.