-
Notifications
You must be signed in to change notification settings - Fork 5.5k
refactor: Unify IoTOperations folder structure per Azure Guidelines #36062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Moved TypeSpec files from IoTOperations.Management/ to resource-manager/Microsoft.IoTOperations/IoTOperations/ - Unified TypeSpec and swagger files under the same service folder structure - Updated tspconfig.yaml with correct emitter output directory and ARM types configuration - Fixed all input-file references in readme.md to use correct relative paths - Added suppressions.yaml for TypeSpecRequirement to handle legacy swagger versions - Ensured compliance with Azure REST API specification folder structure guidelines The new structure follows the pattern: specification/iotoperations/resource-manager/Microsoft.IoTOperations/IoTOperations/ ├── *.tsp (TypeSpec files) ├── tspconfig.yaml ├── readme.md ├── suppressions.yaml ├── examples/ (TypeSpec examples) ├── models/ (TypeSpec models) ├── preview/ (preview swagger versions) └── stable/ (stable swagger versions)
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
The .NET SDK validation failure is due to a known issue for .NET SDK generation: Azure/azure-sdk-for-net#45949. We have a mechanism to flatten a single property out if the model only contains 1 property, and it doesn't work properly for multiple layers of flatten. We can ignore this for now, we can fix it with custom code in sdk repo. Due to code freeze in autorest.csharp, we are about to deprecate it, we will fix this in the new generator instead. |
Next Steps to MergeNext steps that must be taken to merge this PR:
Important checks have failed. As of today they are not blocking this PR, but in near future they may. Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
The new structure follows the pattern:
specification/iotoperations/resource-manager/Microsoft.IoTOperations/IoTOperations/ ├── *.tsp (TypeSpec files)
├── tspconfig.yaml
├── readme.md
├── suppressions.yaml
├── examples/ (TypeSpec examples)
├── models/ (TypeSpec models)
├── preview/ (preview swagger versions)
└── stable/ (stable swagger versions)
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.