Skip to content

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Jul 21, 2025

  • Moved TypeSpec files from IoTOperations.Management/ to resource-manager/Microsoft.IoTOperations/IoTOperations/
  • Unified TypeSpec and swagger files under the same service folder structure
  • Updated tspconfig.yaml with correct emitter output directory and ARM types configuration
  • Fixed all input-file references in readme.md to use correct relative paths
  • Added suppressions.yaml for TypeSpecRequirement to handle legacy swagger versions
  • Ensured compliance with Azure REST API specification folder structure guidelines

The new structure follows the pattern:
specification/iotoperations/resource-manager/Microsoft.IoTOperations/IoTOperations/ ├── *.tsp (TypeSpec files)
├── tspconfig.yaml
├── readme.md
├── suppressions.yaml
├── examples/ (TypeSpec examples)
├── models/ (TypeSpec models)
├── preview/ (preview swagger versions)
└── stable/ (stable swagger versions)

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

- Moved TypeSpec files from IoTOperations.Management/ to resource-manager/Microsoft.IoTOperations/IoTOperations/
- Unified TypeSpec and swagger files under the same service folder structure
- Updated tspconfig.yaml with correct emitter output directory and ARM types configuration
- Fixed all input-file references in readme.md to use correct relative paths
- Added suppressions.yaml for TypeSpecRequirement to handle legacy swagger versions
- Ensured compliance with Azure REST API specification folder structure guidelines

The new structure follows the pattern:
specification/iotoperations/resource-manager/Microsoft.IoTOperations/IoTOperations/
├── *.tsp (TypeSpec files)
├── tspconfig.yaml
├── readme.md
├── suppressions.yaml
├── examples/ (TypeSpec examples)
├── models/ (TypeSpec models)
├── preview/ (preview swagger versions)
└── stable/ (stable swagger versions)
Copy link

openapi-pipeline-app bot commented Jul 21, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Jul 21, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

github-actions bot commented Jul 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.IoTOperations-IoTOperations
TypeSpec Microsoft.IoTOperations
Go sdk/resourcemanager/iotoperations/armiotoperations
Java com.azure.resourcemanager:azure-resourcemanager-iotoperations
JavaScript @azure/arm-iotoperations
Python azure-mgmt-iotoperations

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec labels Jul 21, 2025
@qiaozha qiaozha marked this pull request as ready for review July 21, 2025 05:01
@live1206
Copy link
Member

The .NET SDK validation failure is due to a known issue for .NET SDK generation: Azure/azure-sdk-for-net#45949. We have a mechanism to flatten a single property out if the model only contains 1 property, and it doesn't work properly for multiple layers of flatten. We can ignore this for now, we can fix it with custom code in sdk repo. Due to code freeze in autorest.csharp, we are about to deprecate it, we will fix this in the new generator instead.

@qiaozha qiaozha added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Aug 5, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Aug 25, 2025
Copy link

github-actions bot commented Aug 25, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The suppressions added to the AutoRest config files (README.mds) require review. Refer to step 1 in the PR workflow diagram, or to step 3, depending on the kind of suppression you did.

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Aug 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Sep 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required FolderMigrationV2 A specific label for PRs like folder structure migration into v2. PipelineBotTrigger resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants