Skip to content

Remove Private Decorator in StorageActions #36905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshao25 merged 8 commits into from
Nov 17, 2025
Merged

Remove Private Decorator in StorageActions #36905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16c366b
update
mcgallan Aug 25, 2025
b5ff255
remove suppression in model
mcgallan Aug 25, 2025
1cd4c16
Merge remote-tracking branch 'upstream/main' into remove-private-in-s…
mcgallan Sep 3, 2025
efb7147
Merge branch 'main' into remove-private-in-storageactions
mcgallan Sep 25, 2025
24c3714
Merge branch 'main' into remove-private-in-storageactions
mcgallan Oct 13, 2025
4694101
removed suppression
mcgallan Oct 13, 2025
6980210
Merge branch 'remove-private-in-storageactions' of https://github.com…
mcgallan Oct 13, 2025
ff96dbb
Merge branch 'main' into remove-private-in-storageactions
pshao25 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions specification/storageactions/StorageAction.Management/StorageTask.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,8 @@ namespace Microsoft.StorageActions;
/**
* Represents Storage Task.
*/
#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
@Azure.ResourceManager.Private.armResourceInternal(StorageTaskProperties)
@Http.Private.includeInapplicableMetadataInPayload(false)
model StorageTask extends Foundations.TrackedResource {
model StorageTask
is Azure.ResourceManager.TrackedResource<StorageTaskProperties, false> {
...ResourceNameParameter<
Resource = StorageTask,
KeyName = "storageTaskName",
Expand All @@ -31,12 +27,6 @@ model StorageTask extends Foundations.TrackedResource {
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
identity: Azure.ResourceManager.Foundations.ManagedServiceIdentity;

#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
@doc("The resource-specific properties for this resource.")
@Azure.ResourceManager.Private.armResourcePropertiesOptionality(false)
properties?: StorageTaskProperties;
}

@armResourceOperations
Expand Down
2 changes: 0 additions & 2 deletions specification/storageactions/StorageAction.Management/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ model StorageTaskPreviewAction {
/**
* Properties of the storage task preview.
*/
#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
properties: StorageTaskPreviewActionProperties;
}

Expand Down Expand Up @@ -387,7 +386,6 @@ model StorageTaskUpdateParameters {
/**
* Properties of the storage task.
*/
#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
properties?: StorageTaskUpdateProperties;
}

Expand Down
12 changes: 6 additions & 6 deletions ...geactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,19 +828,19 @@
"type": "object",
"description": "Represents Storage Task.",
"properties": {
"identity": {
"$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentity",
"description": "The managed service identity of the resource."
},
"properties": {
"$ref": "#/definitions/StorageTaskProperties",
"description": "Properties of the storage task.",
"x-ms-client-flatten": true
},
"identity": {
"$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentity",
"description": "The managed service identity of the resource."
}
},
"required": [
"identity",
"properties"
"properties",
"identity"
],
"allOf": [
{
Expand Down
Loading