Skip to content

Update the TSV emitter-output-dir rule as required #37651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 26, 2025
Merged

Update the TSV emitter-output-dir rule as required #37651

merged 14 commits into from
Sep 26, 2025
+19 −37

Conversation

skywing918
Copy link
Contributor

@skywing918 skywing918 commented Sep 23, 2025 •
edited by MaryGao
Loading

Update the TSV emitter-output-dir rule as required. Before switching to emitter-output-dir the relevant rules are optional for .Net and required for rest languages. The pr is to restore the status as it is.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@MaryGao MaryGao changed the title TSV as required TSV emitter-output-dir rule as required Sep 23, 2025
@MaryGao MaryGao changed the title TSV emitter-output-dir rule as required Update the TSV emitter-output-dir rule as required Sep 23, 2025
@github-actions github-actions bot added the TypeSpec Authored with TypeSpec label Sep 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup
Java com.azure.resourcemanager:azure-resourcemanager-recoveryservicesbackup
Go sdk/resourcemanager/devcenter/armdevcenter
Go sdk/resourcemanager/keyvault/armkeyvault
Java com.azure.resourcemanager:azure-resourcemanager-devcenter
Java com.azure.resourcemanager:azure-resourcemanager-keyvault-generated
Go sdk/resourcemanager/nginx/armnginx
Java com.azure.resourcemanager:azure-resourcemanager-nginx
JavaScript @azure/arm-devcenter
JavaScript @azure/arm-keyvault
JavaScript @azure/arm-nginx
JavaScript @azure/arm-recoveryservicesbackup

MaryGao
MaryGao previously requested changes Sep 24, 2025
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending this https://github.com/Azure/azure-rest-api-specs-pr/pull/24593

@weshaggard
Copy link
Member

We should only enable this rule as required if we know it is passing on everything in main and the private RPSaaSMaster.

@MaryGao MaryGao dismissed their stale review September 25, 2025 02:33

The pending pr has been merged.

@MaryGao
Copy link
Member

MaryGao commented Sep 25, 2025

JS failure is un-relevant to this change and it is introduced by our feature gap Azure/autorest.typescript#3391 and the support is in progress.

@MaryGao
Copy link
Member

MaryGao commented Sep 25, 2025 •
edited
Loading

We should only enable this rule as required if we know it is passing on everything in main and the private RPSaaSMaster.

@weshaggard we have two separated prs to update all tspconfigs in the main and private RPSaaSMaster. The TypeSpec validation for all should be passed.

Before switching to emitter-output-dir the relevant rules are optional for .Net and required for rest languages. The pr is to restore the status as it is.

Please note JS has an known issue so one generation failed.

@weidongxu-microsoft @msyyc @tadelesh @live1206 please help review from your language side. Thanks!

@weidongxu-microsoft
Copy link
Member

I've removed the optional logic in TspConfigJavaAzEmitterOutputDirMatchPatternSubRule and TspConfigJavaMgmtEmitterOutputDirMatchPatternSubRule

@MaryGao MaryGao enabled auto-merge (squash) September 26, 2025 11:53
@raych1 raych1 disabled auto-merge September 26, 2025 15:20
@raych1 raych1 merged commit 9453685 into main Sep 26, 2025
75 of 78 checks passed
@raych1 raych1 deleted the TSVRequired branch September 26, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@live1206 live1206 live1206 approved these changes

@MaryGao MaryGao MaryGao approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@msyyc msyyc msyyc approved these changes

@wanlwanl wanlwanl Awaiting requested review from wanlwanl wanlwanl is a code owner

@raych1 raych1 Awaiting requested review from raych1 raych1 is a code owner

@maririos maririos Awaiting requested review from maririos maririos is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees
No one assigned
Labels
BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@skywing918 @weshaggard @MaryGao @weidongxu-microsoft @tadelesh @live1206 @msyyc @raych1