-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Define contract for Batch RuleSet feature #37879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Define contract for Batch RuleSet feature #37879
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
specification/cdn/resource-manager/Microsoft.Cdn/Cdn/RuleSet.tsp
Outdated
Show resolved
Hide resolved
specification/cdn/resource-manager/Microsoft.Cdn/Cdn/stable/2025-06-01/openapi.json
Outdated
Show resolved
Hide resolved
@microsoft-github-policy-service agree company="Microsoft" |
It will be treated as false
…-api-definition-typespec
…b.com:mangoo1/azure-rest-api-specs into 34786717-batch-rulset-api-definition-typespec
So it will be compliance with the ARM spec that requires the body.
|
The remaining error from LintDiff looks valid to me:
You do repeat this in the path and body. Path: Lines 6832 to 6841 in 053e5d8
Body: Lines 16370 to 16378 in 053e5d8
You can either change your spec (and maybe service?) to fix this, or add a suppression: https://github.com/Azure/azure-rest-api-specs/wiki/Swagger-LintDiff#adding-scoped-suppressions |
|
I tend to supress this as that was defined before my changes, would be breaking changes if I remove that.
|


ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.