Skip to content

Conversation

@FumingZhang
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

FumingZhang and others added 6 commits October 9, 2025 23:02
* Add Managed Namespace API to 2025-09-01

* Update summary according to the GA api doc

* run prettier
* add local dns config to agent pool profile

* run prettier on file

* run prettier on managed cluster example

---------

Co-authored-by: juanbe <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 11, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 11, 2025
@github-actions
Copy link

github-actions bot commented Oct 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ContainerService-aks
Go sdk/resourcemanager/containerservice/armcontainerservice
Java com.azure.resourcemanager:azure-resourcemanager-containerserviceaks-generated
JavaScript @azure/arm-containerservice
Python azure-mgmt-containerservice

* Added kata example and api.

* Removed preview wording.
…sion stable/2025-09-01 (#38092)

* sort ossku

* normalize casing of eTag
@psah434 psah434 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 13, 2025
* Add Istio egress GA

Signed-off-by: nshankar <[email protected]>

* Fix style

Signed-off-by: nshankar <[email protected]>

* Update example

Signed-off-by: nshankar <[email protected]>

* Fix example

Signed-off-by: nshankar <[email protected]>

---------

Signed-off-by: nshankar <[email protected]>
@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 16, 2025
@mikekistler mikekistler added the BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep label Oct 20, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 20, 2025
@mikekistler
Copy link
Member

I've approved this breaking change as a "branch policy exception", only because this is the closed description of the explanation for this change. The actual situation is that the REST API as described in GA API versions going back to 2023-08-01, when the IstioEgressGateway schema was first introduced, didn't work as documented. It didn't work because the Egress gateway feature was disabled becuase of flaws discovered in the design. But rather than remove the feature, it was allowed to remain in the GA API for 18 API versions until now, when the design flaw has been corrected an the feature will now be enabled if the user adds the required name field.

@ramoka178
Copy link
Contributor

Approving per the last commit after the initial sign off.

@ramoka178 ramoka178 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 20, 2025
@FumingZhang FumingZhang added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 26, 2025
@FumingZhang
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@FumingZhang
Copy link
Member Author

@jliusan could you please help review the breaking change of go sdk in this PR? Thanks

@jliusan
Copy link
Member

jliusan commented Oct 27, 2025

@jliusan could you please help review the breaking change of go sdk in this PR? Thanks

I updated the branch, and the breaking Change disappeared

@FumingZhang FumingZhang merged commit 58e859f into main Oct 28, 2025
39 of 41 checks passed
@FumingZhang FumingZhang deleted the dev-containerservice-Microsoft.ContainerService-2025-09-01 branch October 28, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Container Service new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.