-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Review request for Microsoft.ContainerService/aks to add version stable/2025-09-01 #38069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.ContainerService/aks to add version stable/2025-09-01 #38069
Conversation
…able/2025-08-01 to version 2025-09-01
* Add Managed Namespace API to 2025-09-01 * Update summary according to the GA api doc * run prettier
Co-authored-by: juanbe <[email protected]>
* add local dns config to agent pool profile * run prettier on file * run prettier on managed cluster example --------- Co-authored-by: juanbe <[email protected]>
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
* Added kata example and api. * Removed preview wording.
…sion stable/2025-09-01 (#38092) * sort ossku * normalize casing of eTag
* Add Istio egress GA Signed-off-by: nshankar <[email protected]> * Fix style Signed-off-by: nshankar <[email protected]> * Update example Signed-off-by: nshankar <[email protected]> * Fix example Signed-off-by: nshankar <[email protected]> --------- Signed-off-by: nshankar <[email protected]>
|
I've approved this breaking change as a "branch policy exception", only because this is the closed description of the explanation for this change. The actual situation is that the REST API as described in GA API versions going back to 2023-08-01, when the IstioEgressGateway schema was first introduced, didn't work as documented. It didn't work because the Egress gateway feature was disabled becuase of flaws discovered in the design. But rather than remove the feature, it was allowed to remain in the GA API for 18 API versions until now, when the design flaw has been corrected an the feature will now be enabled if the user adds the required |
|
Approving per the last commit after the initial sign off. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
@jliusan could you please help review the breaking change of go sdk in this PR? Thanks |
I updated the branch, and the breaking Change disappeared |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.