Skip to content

Conversation

@mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Nov 11, 2025

Description

Fixes a number of bugs in the 6.0.0 release

  • We don't backoff clients if an unexpected exception occurs during startup.
  • All telemetry showed as refresh, including startup. Fixed code and variable name to make it clear.
  • Fixed a bug where one flow wouldn't remove the active client that is backed off. Was mainly an issue in a situation where all clients failed.
  • Slight refactor of getLabelFilter + fixed a bug where Spring profiles are now immutable. Only an issue if you provided 2 or more profiles, and didn't provide a label.
  • Tests to validate getLabelFIlter

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 11, 2025 01:40
@github-actions github-actions bot added the azure-spring All azure-spring related issues label Nov 11, 2025
Copilot finished reviewing on behalf of mrm9084 November 11, 2025 01:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR contains bug fixes for version 6.0.0 of the Azure Spring Cloud App Configuration Config library, addressing issues with immutable profiles handling, client backoff management, and parameter naming clarity.

Key Changes

  • Fixed UnsupportedOperationException when profiles list is immutable by creating a mutable copy before reversing
  • Enhanced client backoff logic to properly remove failed clients from the active clients list
  • Clarified constructor parameter semantics by renaming isRefresh to startup with inverted logic
  • Added missing backoff call in exception handler for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
AppConfigurationKeyValueSelector.java Fixed immutable list issue by creating mutable copy before reversing profiles; improved import organization
ConnectionManager.java Added logic to remove backed-off clients from activeClients list to prevent reuse
AzureAppConfigDataResource.java Renamed constructor parameter from isRefresh to startup with inverted logic for clarity
AzureAppConfigDataLoader.java Added backoffClient call in generic exception handler for consistency with status exception handler
AppConfigurationKeyValueSelectorTest.java Added comprehensive test coverage for label filter and validation logic

mrm9084 and others added 7 commits November 12, 2025 10:50
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/properties/AppConfigurationKeyValueSelectorTest.java

Co-authored-by: Copilot <[email protected]>
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java

Co-authored-by: Copilot <[email protected]>
@mrm9084 mrm9084 requested a review from Copilot November 12, 2025 23:07
Copilot finished reviewing on behalf of mrm9084 November 12, 2025 23:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant