-
Notifications
You must be signed in to change notification settings - Fork 2.1k
6.0.0 bug fixes #47225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
6.0.0 bug fixes #47225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR contains bug fixes for version 6.0.0 of the Azure Spring Cloud App Configuration Config library, addressing issues with immutable profiles handling, client backoff management, and parameter naming clarity.
Key Changes
- Fixed
UnsupportedOperationExceptionwhen profiles list is immutable by creating a mutable copy before reversing - Enhanced client backoff logic to properly remove failed clients from the active clients list
- Clarified constructor parameter semantics by renaming
isRefreshtostartupwith inverted logic - Added missing backoff call in exception handler for consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AppConfigurationKeyValueSelector.java | Fixed immutable list issue by creating mutable copy before reversing profiles; improved import organization |
| ConnectionManager.java | Added logic to remove backed-off clients from activeClients list to prevent reuse |
| AzureAppConfigDataResource.java | Renamed constructor parameter from isRefresh to startup with inverted logic for clarity |
| AzureAppConfigDataLoader.java | Added backoffClient call in generic exception handler for consistency with status exception handler |
| AppConfigurationKeyValueSelectorTest.java | Added comprehensive test coverage for label filter and validation logic |
.../appconfiguration/config/implementation/properties/AppConfigurationKeyValueSelectorTest.java
Outdated
Show resolved
Hide resolved
.../com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java
Outdated
Show resolved
Hide resolved
...om/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataResource.java
Outdated
Show resolved
Hide resolved
...loud/appconfiguration/config/implementation/properties/AppConfigurationKeyValueSelector.java
Outdated
Show resolved
Hide resolved
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/properties/AppConfigurationKeyValueSelectorTest.java Co-authored-by: Copilot <[email protected]>
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Description
Fixes a number of bugs in the 6.0.0 release
getLabelFilter+ fixed a bug where Spring profiles are now immutable. Only an issue if you provided 2 or more profiles, and didn't provide a label.getLabelFIlterAll SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines