-
Notifications
You must be signed in to change notification settings - Fork 495
fix: Expose publicNetworkAccess property to allow enabling/disabling public network access for MongoDB cluster. #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…blic-network-access feat: add publicNetworkAccess parameter to mongo-cluster module
…luster-public-network-access Revert "feat: add publicNetworkAccess parameter to mongo-cluster module"
…blic-network-access-docs
…x/mongo-cluster-public-network-access Revert "Revert "feat: add publicNetworkAccess parameter to mongo-cluster module""
…blic-network-access-changelog chore: update changelog for publicNetworkAccess documentation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
|
||
- None | ||
|
||
## 0.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.2
is already published and has its entry right below this one. Please move line 19 up to line 10, the 'Changes' of version 0.4.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the Set-AVMModule script for this contribution, as per the Contribution Guide?
If not, please do so so that all generated files are updated correctly. No manual changes should be required for the readme (nor compiled JSON files).
@description('Optional. The Microsoft Entra ID authentication identity assignments to be created for the cluster.') | ||
param entraAuthIdentities authIdentityType[]? | ||
|
||
@description('Optional. Controls public network access to the cluster. Allowed values: "Enabled", "Disabled".') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@description('Optional. Controls public network access to the cluster. Allowed values: "Enabled", "Disabled".') | |
@description('Optional. Controls public network access to the cluster.') |
The allowed values are anyways communicated via Linter :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution @jeevankuduvaravindran 💪
@sinedied, I took the liberty of taking a quick look already but as the module's owner I'd appreciate if you could give the update a review yourself.
That said, @jeevankuduvaravindran please make sure to setup your fork as per the contribution guide, run the test workflow for this module and attach a pipeline badge to this PR. It is very important that we validate that all static & deployments tests pass before this PR goes in. Fixed any errors on Upstream main is a lot harder.
Also on that note, I'd highly recommend to create contributions never from your main
branch as it locks you out of any other changes. Also as soon as you set up your fork's test environment, you'll find that there are automatic triggers on main
(which are the ones that would publish your update in Upstream main once the PR is merged). Please make sure your diable your actions/workflows before pushing any changes to your fork's main branch. Otherwise a lot of workflows will start running in your fork you did not plan for 😉 This may help 💪
Description
Expose publicNetworkAccess property to allow disabling public network access for MongoDB cluster. This property is available on mongo cluster API version 'Microsoft.DocumentDB/mongoClusters@2025-07-01-preview' and isnt yet surfaced on AVM module. This will allow the users to enable or disable public network access to mongo cluster. Added relevant documentation to readme.
Fixes #5901
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.