-
Notifications
You must be signed in to change notification settings - Fork 493
Add DNS proxy support to Azure Firewall module #5909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
Warning FAO: AVM Core Team When merging this PR it will trigger all AVM modules to be triggered! Please consider disabling the GitHub actions prior to merging and then re-enable once merged. |
Co-authored-by: hundredacres <[email protected]>
Co-authored-by: hundredacres <[email protected]>
minCapacity: autoscaleMinCapacity | ||
} | ||
firewallPolicy: !empty(firewallPolicyId) | ||
? union( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would highly recommend to use shallowMerge()
via ...(condition ? { properties} : {})
instead of union to preserve linter support
This PR adds support for enabling DNS proxy functionality on Azure Firewall through a new optional
enableDnsProxy
parameter. When enabled, this allows the firewall to act as a DNS proxy and forward DNS requests to configured DNS servers, which is required when using network rules with FQDN destinations.Changes Made
Core Implementation
enableDnsProxy
parameter (optional, defaults tofalse
)additionalProperties
withNetwork.DNS.EnableProxy: 'true'
when DNS proxy is enabledunion()
function for clean conditional mergingDocumentation
Testing
max
test case to includeenableDnsProxy: true
for comprehensive testingbasic
test case to validate compatibility with Basic SKUExample Usage
When
enableDnsProxy
istrue
, the generated ARM template will include:This implementation maintains full backwards compatibility as the parameter defaults to
false
, preserving existing behavior for current deployments.Fixes #4998.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
live-data.bicep.azure.com
bicep build main.bicep
(dns block)bicep build main.bicep --stdout
(dns block)bicep build test_syntax.bicep
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.