fix: DevOps CI/CD agents pattern module DNS properties were not used and added dnsIsDeployedByPolicy property
#5944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added optional parameter 'dnsIsDeployedByPolicy' to control DNS deployment by policy. - Updated private DNS zone group logic to utilize the new parameter.
- Introduced a new parameter `dnsIsDeployedByPolicy` to indicate if the DNS configuration is deployed by policy. - Updated README.md to document the new parameter. - Modified main.json to include the new parameter in the parameters section.
- Updated API version for private DNS zone and container registry modules. - Adjusted references to outputs for new version compatibility. - Updated managed environment and job module versions for consistency.
avm-team-linter
bot
added
the
Needs: Module Owner 📣
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
johnlokerse
changed the title
johnlokerse
changed the title
dnsIsDeployedByPolicy property
johnlokerse
changed the title
dnsIsDeployedByPolicy propertydnsIsDeployedByPolicy property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into some DNS issues when bringing your own DNS setup and when using DINE policies. This pull request removes
privateDnsZoneGroupNameandprivateDnsZoneResourceIdsin moduleacr. These properties were not used. Updated them to the correct properties as defined in the UDT. Additionally, added the parameterdnsIsDeployedByPolicyto be able to skip the configuration of privateDnsZoneGroups.Updated modules to the latest version.
Pipeline Reference
Do you have an environment set up @sebassem so this change can be tested?
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.