feat: capacityReservationGroupResourceId, extensionGuestConfigurationExtension` params added #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: ml registry
Feature/ml registry
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
…ed/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]>
…test.bicep Co-authored-by: Alexander Sehr <[email protected]>
…test.bicep Co-authored-by: Alexander Sehr <[email protected]>
…ed/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]>
…main.test.bicep Co-authored-by: Alexander Sehr <[email protected]>
* vm module update * update readme * main.json updated * vm update with disabled linter rule * dependencies fix after receiving the InvalidPrincipalId message * set avm module * fix issue with role * backupManagementServiceEnterpriseApplicationObjectId * update * backupManagementServiceEnterpriseApplicationObjectId update * changelog update
Co-authored-by: Erika Gressi <[email protected]>
…into Azure-main
* first commit ML registry * ML changes * removing readme and main-json to be generated again by the script * update after running set-avmmodule script * fix test results * resourceGroupName modified * readme update * service endpoint change from registry to amlregistry * update adding more parameters * e2e max test updated * empty line removed * fixes to new params added * Update avm/res/machine-learning-services/registry/version.json Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/waf-aligned/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/max/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/max/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/waf-aligned/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/defaults/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * resource conf change: each region defined will have dedicated storage account and ACR * test-module locally * main.json update * changelog added * module path corrected * Feature/vm update (#3) * vm module update * update readme * main.json updated * vm update with disabled linter rule * dependencies fix after receiving the InvalidPrincipalId message * set avm module * fix issue with role * backupManagementServiceEnterpriseApplicationObjectId * update * backupManagementServiceEnterpriseApplicationObjectId update * changelog update * Update avm/res/compute/virtual-machine/CHANGELOG.md Co-authored-by: Erika Gressi <[email protected]> * capacityReservationGroupResourceId parameter name change * set-avm module * update version.json to 0.17 * ci: Feature/vm update (#5) * vm module update * update readme * main.json updated * vm update with disabled linter rule * dependencies fix after receiving the InvalidPrincipalId message * set avm module * fix issue with role * backupManagementServiceEnterpriseApplicationObjectId * update * backupManagementServiceEnterpriseApplicationObjectId update * changelog update * fix: Feature/vm fixes (#6) * removal of depends on DSC for customscriptextension (issue 2413) * osdick and fileuris * managed disk Id Azure#5535 * set module --------- Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
* first commit ML registry * ML changes * removing readme and main-json to be generated again by the script * update after running set-avmmodule script * fix test results * resourceGroupName modified * readme update * service endpoint change from registry to amlregistry * update adding more parameters * e2e max test updated * empty line removed * fixes to new params added * Update avm/res/machine-learning-services/registry/version.json Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/main.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/waf-aligned/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/max/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/max/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/waf-aligned/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update avm/res/machine-learning-services/registry/tests/e2e/defaults/main.test.bicep Co-authored-by: Alexander Sehr <[email protected]> * resource conf change: each region defined will have dedicated storage account and ACR * test-module locally * main.json update * changelog added * module path corrected * Feature/vm update (#3) * vm module update * update readme * main.json updated * vm update with disabled linter rule * dependencies fix after receiving the InvalidPrincipalId message * set avm module * fix issue with role * backupManagementServiceEnterpriseApplicationObjectId * update * backupManagementServiceEnterpriseApplicationObjectId update * changelog update * Update avm/res/compute/virtual-machine/CHANGELOG.md Co-authored-by: Erika Gressi <[email protected]> * capacityReservationGroupResourceId parameter name change * set-avm module * update version.json to 0.17 * removal of depends on DSC for customscriptextension (issue 2413) * osdick and fileuris * ci: Feature/vm update (#5) * vm module update * update readme * main.json updated * vm update with disabled linter rule * dependencies fix after receiving the InvalidPrincipalId message * set avm module * fix issue with role * backupManagementServiceEnterpriseApplicationObjectId * update * backupManagementServiceEnterpriseApplicationObjectId update * changelog update * managed disk Id Azure#5535 * set module * fix: Virtual-Machine - Updated `encryptionAtHost` usage (Azure#5939) ## Description ### Changes - Adjusted the usage of the `ecryptionAtHost` property to only pass it to the resource provider if enabled ### Breaking Changes - Changing default value of `encryptionAtHost` from `true` to `false` to improve usability for subscription where the feature is or cannot be enabled Fixes Azure#2374 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml) ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation - [ ] Update to CI Environment or utilities (Non-module affecting changes) --------- Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml){kind=link}
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
josunefon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
capacityReservationGroupReourceId, extensionGuestConfigurationExtensionparameters were added.Closes #5535
Closes #5884
Closes #5396
Closes #3941
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.