-
Notifications
You must be signed in to change notification settings - Fork 494
feat: Added Support for Network Security Perimeter, added TLS1.3 for Storage #5975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm/res/document-db/database-account/tests/e2e/perimeter/perimeter.bicep
Outdated
Show resolved
Hide resolved
avm/res/storage/storage-account/tests/e2e/perimeter/perimeter.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments from my side @jhueppauff .
Please note that because this module touches on 2 module that are owned by different people you need both their approvals to get this PR merged.
ping @ktremain & @seesharprun Also @jhueppauff, by now there're unfortunately some conflicts that need resolving. |
Description
Added Support to set "SecuredByPerimeter" for Public Access
Added TLS1.3 as option in the TLS Section of Azure Storage Accounts
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.