-
Notifications
You must be signed in to change notification settings - Fork 512
feat: avm module upgrade for CKM #6195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AjitPadhi-Microsoft
wants to merge
12
commits into
Azure:main
Choose a base branch
from
Ravikirana-Microsoft:ckm-avm-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: avm module upgrade for CKM #6195
AjitPadhi-Microsoft
wants to merge
12
commits into
Azure:main
from
Ravikirana-Microsoft:ckm-avm-update
+54,444
−49,976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Also changelog & version.json needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs: Module Owner 📣
This module needs an owner to develop or maintain it
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes three Bicep modules related to AI Foundry resource provisioning and key management. The modules previously managed the deployment and configuration of AI Hub, AI Services, Search Services, and related Azure resources, as well as the handling of secrets in Azure Key Vault. The removal simplifies the codebase and likely reflects a shift to newer, more secure, or standardized deployment patterns.
The most important changes are:
Removal of AI Foundry resource provisioning modules:
ai-foundry.bicepmodule, which orchestrated the deployment of multiple Azure resources (AI Hub, AI Project, AI Services, Search, Storage, Container Registry, Application Insights) and managed their configuration and interconnections.ai-foundry-ai-hub.bicepmodule, responsible for provisioning and configuring the AI Hub resource, including its connections to Cognitive Services and Search, and passing resource keys.Removal of Key Vault secret management:
ai-foundry-kv-secret-cog-services-key.bicepmodule, which handled storing Cognitive Services keys as secrets in Azure Key Vault.Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.