Add support for licensed pbs professional #81
Conversation
Bumps [zipp](https://github.com/jaraco/zipp) from 3.6 to 3.19.1. - [Release notes](https://github.com/jaraco/zipp/releases) - [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst) - [Commits](jaraco/zipp@v3.6.0...v3.19.1) --- updated-dependencies: - dependency-name: zipp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Removed remaining cganglia reference
build.sh sets up a venv, runs package.py, and overwrites release.yml
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Altair PBS Professional (licensed commercial version) to the existing CycleCloud PBS project. It introduces a dedicated cluster template and modifies Chef recipes to handle both open source OpenPBS and commercial PBS Professional installations.
Key changes:
- Added new PBS Professional cluster template with comprehensive configuration options
- Enhanced Chef recipes to conditionally handle PBS Professional vs OpenPBS package installation
- Added comprehensive documentation for PBS Professional setup and configuration
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/pbspro.txt | New PBS Professional cluster template with full configuration parameters |
| templates/openpbs.txt | Added professional flag to distinguish from PBS Professional |
| specs/default/chef/site-cookbooks/pbspro/recipes/server.rb | Enhanced server recipe to handle PBS Professional packages and licensing |
| specs/default/chef/site-cookbooks/pbspro/recipes/login.rb | Updated login recipe for PBS Professional client packages |
| specs/default/chef/site-cookbooks/pbspro/recipes/execute.rb | Modified execute recipe for PBS Professional execution packages |
| specs/default/chef/site-cookbooks/pbspro/attributes/default.rb | Added default attributes for PBS Professional configuration |
| README.md | Added comprehensive documentation for PBS Professional setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Widget.Plugin = pico.form.BooleanCheckBox | ||
| Widget.Label = Add NFS mount | ||
|
|
||
| [[[parameter AdditonalNFSAddress]]] |
There was a problem hiding this comment.
The parameter name has a typo. 'AdditonalNFSAddress' should be 'AdditionalNFSAddress' (missing 'i' in 'Additional').
| [[[parameter AdditonalNFSAddress]]] | |
| [[[parameter AdditionalNFSAddress]]] |
|
|
||
| # May be used to identify the ID in cluster-init scripts | ||
| cluster.identities.default = $ManagedIdentity | ||
|
|
There was a problem hiding this comment.
Line contains only a tab character. This should be removed as it's unnecessary whitespace.
| [[[cluster-init cyclecloud/pbspro:login]]] | ||
|
|
||
| [[[configuration]]] |
There was a problem hiding this comment.
Inconsistent indentation using tabs instead of spaces. The rest of the file uses spaces for indentation.
| [[[cluster-init cyclecloud/pbspro:login]]] | |
| [[[configuration]]] | |
| [[[cluster-init cyclecloud/pbspro:login]]] | |
| [[[configuration]]] |
| [[[parameter NFSDiskWarning]]] | ||
| HideLabel = true |
There was a problem hiding this comment.
Inconsistent indentation using tabs instead of spaces. The rest of the file uses spaces for indentation.
| [[[parameter NFSDiskWarning]]] | |
| HideLabel = true | |
| [[[parameter NFSDiskWarning]]] | |
| HideLabel = true |
| Config.MinValue = 0 | ||
| Config.MaxValue = 10000 | ||
| Config.IntegerOnly = true | ||
|
|
There was a problem hiding this comment.
Line contains only a tab character. This should be removed as it's unnecessary whitespace.
| code <<-EOH | ||
| /opt/pbs/bin/qmgr -c 'set server pbs_license_info=#{pbspro_license}' | ||
| EOH |
There was a problem hiding this comment.
There's trailing whitespace at the end of line 110. This should be removed for consistency.
4 participants
Altair PBS Professional support