Skip to content

Conversation

@p3dr0rv
Copy link
Contributor

@p3dr0rv p3dr0rv commented Sep 13, 2024

Something changed on ADO and that caused the pipeline to stop running on PR, the solution was to remove the trigger tag.

If you didn't specify any triggers, and the Disable implied YAML CI trigger setting is not enabled, the default is as if you wrote:

trigger:
  branches:
    include:
    - '*'  # must quote since "*" is a YAML reserved character; we want a string

@p3dr0rv p3dr0rv requested a review from a team as a code owner September 13, 2024 06:58
@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@p3dr0rv p3dr0rv added No-Changelog This Pull-Request has no associated changelog entry. skip AB ID validation labels Sep 13, 2024
@p3dr0rv p3dr0rv changed the title Update validate-pr-ab-id.yml Remove triggers from pipelines and execute ABID validator on label change Sep 13, 2024
@SammyO
Copy link
Contributor

SammyO commented Sep 13, 2024

@p3dr0rv do we know why this was introduced and thus if we're okay to remove these checks? To rephrase: are we sure we're not disabling some new (security?) initiative?

@p3dr0rv
Copy link
Contributor Author

p3dr0rv commented Sep 13, 2024

@p3dr0rv do we know why this was introduced and thus if we're okay to remove these checks? To rephrase: are we sure we're not disabling some new (security?) initiative?

I think it's ok to remove this section, I wrote these files, and they worked at the time. Now it seems the logic for triggering the pipes is different.

@p3dr0rv p3dr0rv merged commit 604c5c9 into dev Sep 13, 2024
43 checks passed
@p3dr0rv p3dr0rv deleted the pedroro/trigger-pipeline branch September 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants