Fix - [CodeQL.SM03853] Removing that accepts all certificates, Fixes AB#3064771 #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
shahzaibj
approved these changes
Oct 8, 2024
fadidurah
approved these changes
Oct 8, 2024
|
✅ Work item link check complete. Description contains link AB#3064771 to an Azure Boards work item. |
github-actions
bot
changed the title
TrustManager that accepts all certificates
iamgusain
added
Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue reported by CodeQL
Removing code path in testing libraries (keyvault and labapi) which uses TrustManager that accepts all certificates for SSL verification. This code path is not secure and can lead to potential security vulnerabilities and should not be used in production code.
AB#3064771