- 
                Notifications
    You must be signed in to change notification settings 
- Fork 46
Migrate URIBuilder to httpcore5, Fixes AB#2909378 #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | ❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. | 
| ✅ Work item link check complete. Description contains link AB#2909378 to an Azure Boards work item. | 
              
                    fadidurah
  
              
              approved these changes
              
                  
                    Oct 25, 2024 
                  
              
              
            
            
              
                    p3dr0rv
  
              
              reviewed
              
                  
                    Oct 25, 2024 
                  
              
              
            
            
              
                    p3dr0rv
  
              
              reviewed
              
                  
                    Oct 25, 2024 
                  
              
              
            
            
              
                    p3dr0rv
  
              
              approved these changes
              
                  
                    Oct 25, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, leave a few questions
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Part 1 of the work to get rid msebera.httpclient.
AB#2909378
Migrate the usage of uribuilder to httpcore5