Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
vNext
---------
- [MINOR] On GetPreferredAuthMethod return NONE when Authenticator is not installed (#2523)

Version 18.1.0
----------
(common4j 15.1.0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import androidx.annotation.NonNull;
import androidx.annotation.WorkerThread;

import com.microsoft.identity.common.internal.broker.BrokerData;
import com.microsoft.identity.common.internal.commands.RefreshOnCommand;
import com.microsoft.identity.common.internal.telemetry.Telemetry;
import com.microsoft.identity.common.internal.telemetry.events.ApiEndEvent;
Expand All @@ -49,7 +48,6 @@
import com.microsoft.identity.common.java.dto.AccountRecord;
import com.microsoft.identity.common.java.eststelemetry.PublicApiId;
import com.microsoft.identity.common.java.exception.ArgumentException;
import com.microsoft.identity.common.java.exception.BrokerRequiredException;
import com.microsoft.identity.common.java.exception.ClientException;
import com.microsoft.identity.common.java.exception.ErrorStrings;
import com.microsoft.identity.common.java.exception.ServiceException;
Expand Down Expand Up @@ -539,14 +537,10 @@ public boolean removeAccount(
*
*/
@Override
public PreferredAuthMethod getPreferredAuthMethod() throws BrokerRequiredException {
public PreferredAuthMethod getPreferredAuthMethod() {
final String methodTag = TAG + ":getPreferredAuthMethod";
final BrokerRequiredException exception = new BrokerRequiredException(
BrokerData.getProdMicrosoftAuthenticator().getPackageName(),
null
);
Logger.error(methodTag, "Broker required.", exception);
throw exception;
Logger.warn(methodTag, "BrokerController is required, return PreferredAuthMethod.NONE");
return PreferredAuthMethod.NONE;
}

@Override
Expand Down

This file was deleted.

Loading