Skip to content

Conversation

somalaya
Copy link
Contributor

@somalaya somalaya commented Oct 10, 2025

  1. In brokerless scenarios, we cannot control flighting the features.
  2. WebCp in webview feature is planned to be first rolled out in brokered scenarios using flighting (slowing going from 25 to 100% in 4 weeks)
  3. Once we complete step 2 above, we want to enable the feature by default in brokerless scenarios as well.
  4. But in case there are any issues found, we also want to be able to provide a kill switch to calling apps to turn the feature off.
  5. This PR takes a boolean value from OneAuth to decide whether to show webcp in webview or not.
  6. Changes are made in OneAuth side as well for passing the value.

Fixes AB#3407952

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@somalaya somalaya marked this pull request as ready for review October 14, 2025 16:37
@somalaya somalaya requested a review from a team as a code owner October 14, 2025 16:37
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 16:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a kill‑switch style flag to control handling of WebCP pages inside the embedded WebView for brokerless scenarios. Key change enables optionally treating WebCP flows in WebView when not running under AuthService, wiring a new boolean through parameters, intent extras, fragment state, and the WebView client.

  • Introduces isWebViewWebCpEnabled flag in AuthorizationActivityParameters and propagates via intent extras.
  • Extends AzureActiveDirectoryWebViewClient logic to allow WebCP-in-WebView in brokerless flows based on the new flag.
  • Saves/restores the new flag in WebViewAuthorizationFragment instance state.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
AzureActiveDirectoryWebViewClient.java Adds brokerless feature flag field and alters WebCP enablement logic.
WebViewAuthorizationFragment.java Stores, restores, and passes the new brokerless WebCP flag to the WebView client.
AuthorizationActivityParameters.kt Adds isWebViewWebCpEnabled parameter and KDoc entry.
AuthorizationActivityFactory.kt Injects the new flag into the authorization intent extras.
AuthenticationConstants.java Defines intent extra key for the new WebCP flag.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@somalaya somalaya force-pushed the somalaya/takeFlightValFromOneAuth branch from eb4d81d to bc1aafc Compare October 20, 2025 16:33
@somalaya somalaya changed the title Take flight value for whether to show webcp flow in weview or not in brokerless scenarios Take flight value for whether to show webcp flow in weview or not in brokerless scenarios. Fixes AB#3407952 Oct 21, 2025
@github-actions
Copy link

✅ Work item link check complete. Description contains link AB#3407952 to an Azure Boards work item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants