-
Notifications
You must be signed in to change notification settings - Fork 46
Take flight value for whether to show webcp flow in weview or not in brokerless scenarios. Fixes AB#3407952 #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a kill‑switch style flag to control handling of WebCP pages inside the embedded WebView for brokerless scenarios. Key change enables optionally treating WebCP flows in WebView when not running under AuthService, wiring a new boolean through parameters, intent extras, fragment state, and the WebView client.
- Introduces isWebViewWebCpEnabled flag in AuthorizationActivityParameters and propagates via intent extras.
- Extends AzureActiveDirectoryWebViewClient logic to allow WebCP-in-WebView in brokerless flows based on the new flag.
- Saves/restores the new flag in WebViewAuthorizationFragment instance state.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
AzureActiveDirectoryWebViewClient.java | Adds brokerless feature flag field and alters WebCP enablement logic. |
WebViewAuthorizationFragment.java | Stores, restores, and passes the new brokerless WebCP flag to the WebView client. |
AuthorizationActivityParameters.kt | Adds isWebViewWebCpEnabled parameter and KDoc entry. |
AuthorizationActivityFactory.kt | Injects the new flag into the authorization intent extras. |
AuthenticationConstants.java | Defines intent extra key for the new WebCP flag. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Outdated
Show resolved
Hide resolved
...a/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityParameters.kt
Show resolved
Hide resolved
...a/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityParameters.kt
Show resolved
Hide resolved
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Outdated
Show resolved
Hide resolved
eb4d81d
to
bc1aafc
Compare
✅ Work item link check complete. Description contains link AB#3407952 to an Azure Boards work item. |
Fixes AB#3407952