Add new span name for DELEGATION_CERT_INSTALL's telemetry, Fixes AB#3362392 #2790
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3362392 to an Azure Boards work item. |
github-actions
bot
changed the title
rpdome
changed the title
rpdome
force-pushed
the
rapong/delegateCheck
branch
from
2bee50c to
ec2c430
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new telemetry span name InstallCertOnWpj to track certificate installation operations on WPJ (Workplace Join) devices, addressing work item AB#3362392.
- Added
InstallCertOnWpjenum value to theSpanNameenum for telemetry tracking - Updated changelog to document the addition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java | Added new InstallCertOnWpj enum value for certificate installation telemetry |
| changelog.txt | Documented the new span name addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,5 +1,6 @@ | |||
| vNext | |||
| ---------- | |||
| - [MINOR] Add new span name for DELEGATION_CERT_INSTALL's telemetry (#2790s) | |||
There was a problem hiding this comment.
The PR reference appears to have a typo. '#2790s' should likely be '#2790' (without the 's').
Suggested change
| - [MINOR] Add new span name for DELEGATION_CERT_INSTALL's telemetry (#2790s) | |
| - [MINOR] Add new span name for DELEGATION_CERT_INSTALL's telemetry (#2790) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://github.com/AzureAD/ad-accounts-for-android/pull/3254
AB#3362392