adjust ltw tests, Fixes AB#3382033 #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3382033 to an Azure Boards work item. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes outdated LTW (Learn To Work) test cases that relied on deprecated "Old" APKs and removes unnecessary API 29 restrictions from remaining test cases. The changes streamline the test suite by eliminating obsolete test scenarios and modernizing the remaining tests to support newer Android versions.
- Removes 4 complete test cases that used deprecated "Old" APK installations
- Removes @RunOnAPI29Minus annotations from 2 remaining test cases
- Updates build configuration with test retry functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TestCase2582292.java | Completely removed - tested LTW as active broker with old MSAL in shared device mode |
| TestCase2582291.java | Completely removed - tested LTW as active broker with MSAL through Company Portal |
| TestCase2582290.java | Completely removed - tested LTW as active broker with MSAL through Authenticator |
| TestCase2571508.java | Completely removed - tested SSO with brokerless LTW installation |
| TestCase2571345.java | Completely removed - Samsung GA coverage test case |
| TestCase2572249.java | Removed API 29 restriction annotation |
| TestCase2571361.java | Removed API 29 restriction annotation |
| msal/build.gradle | Added test retry configuration |
| common | Updated submodule commit reference |
github-actions
bot
changed the title
siddhijain
approved these changes
Oct 1, 2025
rpdome
reviewed
Oct 7, 2025
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582290.java
Show resolved
Hide resolved
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582291.java
Show resolved
Hide resolved
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582292.java
Show resolved
Hide resolved
rpdome
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some old ltw tests that use "Old" apks, also remove usage of api 29 in remaining ltw tests (oneauthtestapp no longer needs api 29 minus).
AB#3382033