ImdsV2: Throw on MTLS when OS is not Windows #5520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to throw an exception when attempting to use IMDSv2 MTLS authentication on non-Windows platforms, as this feature is only supported on Windows.
- Introduces a new error message for non-Windows platform validation
- Refactors the MTLS validation logic to use a local function for cleaner error handling
- Adds platform-specific checks using
DesktopOsHelper.IsWindows()before the existing .NET Framework version check
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MsalErrorMessage.cs | Adds new error message constant for non-Windows platform restriction |
| AcquireTokenForClientParameterBuilder.cs | Implements platform validation logic and refactors error handling with local function |
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Oct 4, 2025
gladjohn
approved these changes
Oct 4, 2025
bgavrilMS
approved these changes
Oct 5, 2025
Robbie-Microsoft
merged commit 1c399c3
into
rginsburg/msiv2_feature_branch
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not unit-testable