Android broker does not support adfs authority #5522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
Oct 6, 2025
src/client/Microsoft.Identity.Client/Platforms/Android/Broker/AndroidBrokerHelper.cs
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
Oct 6, 2025
…AndroidBrokerHelper.cs Co-authored-by: Gladwin Johnson <[email protected]>
gladjohn
approved these changes
Oct 7, 2025
|
Oh, I need two reviewers |
gladjohn
approved these changes
Oct 7, 2025
MZOLN
approved these changes
Oct 7, 2025
bgavrilMS
reviewed
Oct 8, 2025
| using (_logger.LogMethodDuration()) | ||
| { | ||
| // ADFS is not supported with broker | ||
| if (authorityType == AuthorityType.Adfs) |
There was a problem hiding this comment.
nit: I would have done smth like if (authorityType != AAD) { throw }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5017
Changes proposed in this request
Testing
Performance impact
Documentation