Updating MSAL to send client info = 2 on client credential flow #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Oct 14, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Show resolved
Hide resolved
added 2 commits
October 14, 2025 21:36
added test
bgavrilMS
reviewed
Oct 15, 2025
bgavrilMS
reviewed
Oct 15, 2025
src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
bgavrilMS
reviewed
Oct 20, 2025
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 22, 2025
src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 22, 2025
src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 22, 2025
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 22, 2025
| { | ||
| if (CreateClientInfoForS2S) | ||
| { | ||
| return Base64UrlHelpers.Encode("{\"xms_acb\":[\"value1\",\"value2\"]}"); |
There was a problem hiding this comment.
What is xms_acb? Can you add some comment to explain this?
| var idtItem = tuple.Item2; | ||
| Account account = tuple.Item3; | ||
|
|
||
| atItem.AddAdditionalCacheParameters(clientInfoFromServer.AdditionalResponseParameters); |
There was a problem hiding this comment.
What values are we supposed to get from the server for client info?
| using Microsoft.Identity.Client.TelemetryCore.Internal.Events; | ||
| using Microsoft.Identity.Client.Utils; | ||
| using System.Security.Cryptography.X509Certificates; | ||
| using System.Linq; |
neha-bhargava
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#5537
Added:
[OAuth2Parameter.ClientInfo]= "2" to the body parameters in theClientCredentialRequestThis ensures that client credential requests now include the client info parameter with a value of "2".
This tells ESTS to include xms_acb in the token response
Changes proposed in this request
Testing
Performance impact
Documentation