-
Notifications
You must be signed in to change notification settings - Fork 378
[MSI V2] - Adds Authentication Operation to MSI v2 mTLS flows #5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
ImdsV2: Merge into Main
gladjohn
merged 4 commits into
rginsburg/msiv2_feature_branch
from
gladjohn/pop_auth_operation
Oct 24, 2025
Merged
[MSI V2] - Adds Authentication Operation to MSI v2 mTLS flows #5533
gladjohn
merged 4 commits into
rginsburg/msiv2_feature_branch
from
gladjohn/pop_auth_operation
Oct 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/client/Microsoft.Identity.Client/Internal/Requests/ManagedIdentityAuthRequest.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Internal/Requests/ManagedIdentityAuthRequest.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/AuthenticationRequestParameters.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
...t/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenForManagedIdentityParameters.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 20, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will re-review after you've had a chance to respond to all feedback.
src/client/Microsoft.Identity.Client/Internal/Requests/ManagedIdentityAuthRequest.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
Robbie-Microsoft
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes -
Changes proposed in this request
• Purpose: Persist and reuse mTLS binding certificate to enable cache lookups under mtls_pop scheme.
• Non-goals: Certificate rotation strategy, multi-cert pool, persistence across processes.
• Follow-up items: (a) Coalescing concurrent first-mint, (b) Attaching binding cert to result (if not in this PR), (c) Tests enabling previously skipped assertions.
• Risk assessment: Low; internal-only; no behavior change for bearer path.
Testing
unit tests
Performance impact
none
Documentation