Enable IAuthenticationOperation2 to reject MSAL cached tokens and fetch new ones from ESTS #5567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not sure what the purpose for this is, but you cannot add a method to an itnerface. See #5376 |
bgavrilMS
reviewed
Nov 4, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Nov 4, 2025
src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Nov 4, 2025
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation.cs
Outdated
Show resolved
Hide resolved
added 3 commits
November 5, 2025 14:31
trwalke
changed the title
bgavrilMS
reviewed
Nov 12, 2025
| Task FormatResultAsync(AuthenticationResult authenticationResult, CancellationToken cancellationToken = default); | ||
|
|
||
| /// <summary> | ||
| /// Determines whether the cached token is still valid. |
Member
There was a problem hiding this comment.
Suggested change
| /// Determines whether the cached token is still valid. | |
| /// Determines whether the cached token is still valid. Only works for client_credentials flow |
bgavrilMS
approved these changes
Nov 12, 2025
gladjohn
reviewed
Nov 12, 2025
src/client/Microsoft.Identity.Client/AuthScheme/IAuthenticationOperation2.cs
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
Nov 12, 2025
Co-authored-by: Gladwin Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Adding
Task<bool> ValidateCachedTokenAsync(MsalCacheValidationData)toIAuthenticationOperation2This method will allow the implementation of IAuthenticationOperation2 (extensions) to validate if the cached token is still valid. If the token is not valid, this will tell MSAL to not use the token and to fetch a new one from ESTS. If the token is valid, MSAL will proceed as normal.
MsalCacheValidationDataprovides the data to the extension to enable it to determine if the token is valid.Testing
Unit tests
Performance impact
Documentation