-
Notifications
You must be signed in to change notification settings - Fork 379
Add .NET 10 multi-targeting support #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gladjohn <[email protected]>
Co-authored-by: gladjohn <[email protected]>
Co-authored-by: gladjohn <[email protected]>
Co-authored-by: gladjohn <[email protected]>
Directory.Build.props
Outdated
| <Project> | ||
| <!-- Check if .NET 10 SDK is available for conditional multi-targeting --> | ||
| <PropertyGroup> | ||
| <DotNet10SdkAvailable Condition="'$(NETCoreSdkVersion)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0'))">true</DotNet10SdkAvailable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot We do not need this check. DotNet10SdkAvailable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the DotNet10SdkAvailable check from Directory.Build.props and all project files. All projects now directly target both net8.0 and net10.0 without conditional logic. (06ed251)
Co-authored-by: gladjohn <[email protected]>
|
Why are we doing this @gladjohn ? |
an easy way to get net 10 for the httpclient testing Chris and I were doing. This can be closed. |
Fixes #5576
Changes proposed in this request
Added .NET 10 multi-targeting across all MSAL libraries, tests, and dev apps while maintaining .NET 8 compatibility.
Projects now use straightforward multi-targeting:
For mobile platforms:
All projects now build for both .NET 8 and .NET 10 without conditional logic.
Testing
Verified all modified projects build successfully. No code changes required—only project configuration updates.
Performance impact
None. Configuration-only changes.
Documentation
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.