Skip to content

Conversation

Copy link

Copilot AI commented Nov 12, 2025

Fixes #5576

Changes proposed in this request

Added .NET 10 multi-targeting across all MSAL libraries, tests, and dev apps while maintaining .NET 8 compatibility.

  • Client libraries (5 projects): Microsoft.Identity.Client (including Android/iOS with net10.0-android and net10.0-ios), Extensions.Msal, MtlsPop, Desktop.WinUI3 now directly target net10.0 alongside net8.0
  • Test projects (4 projects): Unit, Integration, E2E, Performance tests updated to target net10.0
  • Dev apps (9 projects): NetCoreTestApp, WebApi, CacheExtension, MacConsoleAppWithBroker, TestTelemetry, and Managed Identity apps updated

Projects now use straightforward multi-targeting:

<TargetFrameworks>net8.0;net10.0</TargetFrameworks>

For mobile platforms:

<TargetFrameworkNetAndroid>net8.0-android</TargetFrameworkNetAndroid>
<TargetFrameworkNetIos>net8.0-ios</TargetFrameworkNetIos>
<TargetFrameworkNet10Android>net10.0-android</TargetFrameworkNet10Android>
<TargetFrameworkNet10Ios>net10.0-ios</TargetFrameworkNet10Ios>

All projects now build for both .NET 8 and .NET 10 without conditional logic.

Testing

Verified all modified projects build successfully. No code changes required—only project configuration updates.

Performance impact

None. Configuration-only changes.

Documentation

  • All relevant documentation is updated.
Original prompt

This section details on the original issue you should resolve

<issue_title>[Engineering task] Update MSAL to use Net 10</issue_title>
<issue_description>### Task type

Development

Description

[Engineering task] Update MSAL to use Net 10

Solution

[Engineering task] Update MSAL to use Net 10</issue_description>

<agent_instructions>update product code and tests</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@gladjohn We need to support both net 8 and net 10

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update MSAL to support .NET 10 Add conditional .NET 10 multi-targeting support Nov 12, 2025
Copilot AI requested a review from gladjohn November 12, 2025 17:44
Copilot finished work on behalf of gladjohn November 12, 2025 17:44
<Project>
<!-- Check if .NET 10 SDK is available for conditional multi-targeting -->
<PropertyGroup>
<DotNet10SdkAvailable Condition="'$(NETCoreSdkVersion)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(NETCoreSdkVersion)', '10.0'))">true</DotNet10SdkAvailable>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot We do not need this check. DotNet10SdkAvailable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the DotNet10SdkAvailable check from Directory.Build.props and all project files. All projects now directly target both net8.0 and net10.0 without conditional logic. (06ed251)

Copilot AI changed the title Add conditional .NET 10 multi-targeting support Add .NET 10 multi-targeting support Nov 12, 2025
Copilot AI requested a review from gladjohn November 12, 2025 18:41
Copilot finished work on behalf of gladjohn November 12, 2025 18:41
@bgavrilMS
Copy link
Member

Why are we doing this @gladjohn ?

@gladjohn
Copy link
Contributor

Why are we doing this @gladjohn ?

an easy way to get net 10 for the httpclient testing Chris and I were doing. This can be closed.

@gladjohn gladjohn closed this Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Engineering task] Update MSAL to use Net 10

3 participants