-
Notifications
You must be signed in to change notification settings - Fork 210
Add OIDC issuer validation #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Avery-Dunn
wants to merge
4
commits into
dev
Choose a base branch
from
avdunn/issuer-validation
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 21, 2025
bgavrilMS
approved these changes
Jul 21, 2025
rayluo
requested changes
Jul 23, 2025
Contributor
rayluo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are discussing in this offline conversation on Teams.
bgavrilMS
reviewed
Jul 28, 2025
bgavrilMS
approved these changes
Jul 30, 2025
bgavrilMS
approved these changes
Jul 30, 2025
Member
|
@rayluo - any updates on this? |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new validation according to: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3268768
The issuer returned by the call to the OIDC endpoint (.well-known/openid-configuration) is valid if one of the following is true:
The validation behavior was added to
authority.py, and new tests were added totest_authority.pyto cover itIn addition, a few other tests in
test_authority.pyandtest_application.pywere given valid issuers in their mocked OIDC discovery responses in order to pass validation, but were otherwise unchanged.(this is the full implementation of the work started in this draft PR: #830)