Abstractions is now fully AoT compatible and durability ensured by a new AotTest #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
commented
May 1, 2025
src/Microsoft.Identity.Abstractions/Microsoft.Identity.Abstractions.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Abstractions/Microsoft.Identity.Abstractions.csproj
Show resolved
Hide resolved
jennyf19
approved these changes
May 9, 2025
test/Microsoft.Identity.Abstractions.AotTests/Microsoft.Identity.Abstractions.AotTests.csproj
Outdated
Show resolved
Hide resolved
…tions.csproj Co-authored-by: Keegan <[email protected]> Signed-off-by: Jean-Marc Prieur <[email protected]>
…tions.csproj Co-authored-by: Keegan <[email protected]> Signed-off-by: Jean-Marc Prieur <[email protected]>
Add more testing
jennyf19
approved these changes
May 16, 2025
| /// <remarks>BE CAREFUL when you serialize a credential description. The secrets it contains | ||
| /// will be serialized too depending on the CredentialSource (ClientSecret, Base64Encoded, and Password)</remarks> | ||
| [RequiresDynamicCode("Uses JsonSerializer which may require dynamic code generation for certain types.")] | ||
| [RequiresUnreferencedCode("Uses JsonSerializer which may require dynamic code generation for certain types.")] |
Contributor
There was a problem hiding this comment.
For DecryptKeysAuthenticationOptions, we could check if the options has a TypeInfoResolver, and if it doesn't then we could clone the options, and create a source generated context.
| /// of credential information based on SourceType. | ||
| /// </summary> | ||
| /// <remarks>BE CAREFUL when you serialize a credential description. The secrets it contains | ||
| /// will be serialized too depending on the CredentialSource (ClientSecret, Base64Encoded, and Password)</remarks> |
Contributor
There was a problem hiding this comment.
We should expand the docs that for CustomSignedAssertionProviderData, JsonSerializerOptions.TypeInfoResolver can be used.
| <PublishAot>true</PublishAot> | ||
| <StartupObject>Mise.Configuration.Aot.Tests.Program</StartupObject> | ||
| <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator> | ||
| <!--<NoWarn>SYSLIB1100;SYSLIB1101;SYSLIB0026;SYSLIB0027;SYSLIB0028</NoWarn>--> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!--<NoWarn>SYSLIB1100;SYSLIB1101;SYSLIB0026;SYSLIB0027;SYSLIB0028</NoWarn>--> |
jmprieur
changed the title
This was referenced May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186 186
Note that with C#15, we can do better with an extension property:
// Extension property (C# 15)
implicit extension XExtensions for X
{
public X509Certificate2 Certificate
{
get => this.GetCertificate();
set => this.SetCertificate(value);
}
}