Open
Conversation
02ggang9
approved these changes
Mar 15, 2024
Collaborator
02ggang9
left a comment
02ggang9
left a comment
There was a problem hiding this comment.
오늘 라식해서 조금 뿌옇게 보이는데 선배님 코드는 뚜렷하게 보입니다..bb
스터디 완주해 주셔서 정말로 감사드리고 수고 많으셨습니다~~~!!
| import java.time.DayOfWeek.* | ||
| import java.time.Month | ||
|
|
||
| class OncallDate(val month: Month, private val startDayOfWeek: DayOfWeek) { |
Collaborator
There was a problem hiding this comment.
JDK 표준 라이브러리가 있는지 몰랐네요..!! 유용하게 잘 쓰겠습니다~!! bb
| private var index = 0 | ||
| private var queueMember: String? = null | ||
|
|
||
| fun getNextTurnMember(previousMember: String?) = |
Collaborator
There was a problem hiding this comment.
식이 본문인 함수 사용 bb 인 것 같습니다~!
| return holidayMap.toMap() | ||
| } | ||
|
|
||
| private fun isHoliday(dayOfWeek: DayOfWeek, day: Int) = when (dayOfWeek) { |
Collaborator
There was a problem hiding this comment.
리턴 타입이 Boolean 이라고 생각되게 만드는 메서드 명인 것 같습니다~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
산타 과제 끝나자마자 구현만 해놓고 PR 올리는걸 잊고있었네요...
상태를 가지는 클래스가 생기면서 개발이 더 복잡해지고 어려워 지는 것 같네요 ㅎㅎ