Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds a new vcpkg port for libnotify version 0.8.8, a library for sending desktop notifications on Linux systems. The port includes proper configuration, patch files for compatibility, and follows standard vcpkg port structure.
Changes:
- Added libnotify vcpkg.json with version 0.8.8, dependencies (gdk-pixbuf, glib), and optional introspection feature
- Added portfile.cmake with meson build configuration, download URLs, and installation steps
- Added two patch files to fix parameter naming and enable static builds
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| 3rdParty/vcpkg_ports/ports/libnotify/vcpkg.json | Defines libnotify port metadata, version 0.8.8, dependencies, and introspection feature |
| 3rdParty/vcpkg_ports/ports/libnotify/portfile.cmake | Configures meson build system, downloads source from GNOME mirrors, applies patches, and handles installation |
| 3rdParty/vcpkg_ports/ports/libnotify/0001-fix-parameter-name-omitted-error.patch | Adds parameter names to function signature to fix compilation errors |
| 3rdParty/vcpkg_ports/ports/libnotify/0002-fix-static-build.patch | Changes shared_library to library call to support static builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| vcpkg_list(SET RELEASE_OPTIONS) | ||
| if("introspection" IN_LIST FEATURES) | ||
| vcpkg_list(APPEND RELEASE_OPTIONS -Dintrospection=enabled) | ||
| vcpkg_get_gobject_introspection_programs(PYTHON3 GIR_COMPILER GIR_SCANNER) | ||
| else() | ||
| vcpkg_list(APPEND RELEASE_OPTIONS -Dintrospection=disabled) | ||
| endif() | ||
|
|
||
| vcpkg_configure_meson( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -Dtests=false | ||
| -Dman=false | ||
| -Dgtk_doc=false | ||
| -Ddocbook_docs=disabled | ||
| OPTIONS_RELEASE | ||
| ${RELEASE_OPTIONS} |
There was a problem hiding this comment.
The variable name RELEASE_OPTIONS is inconsistent with the naming convention used in other similar ports in this repository. Other GNOME library ports (gdk-pixbuf at line 22 and gtk3 at line 35) use OPTIONS_RELEASE for this purpose. Consider renaming RELEASE_OPTIONS to OPTIONS_RELEASE to maintain consistency across the codebase, even though both approaches are functionally equivalent.
Summary by cubic
Add a vcpkg overlay port for libnotify 0.8.8 with patches to fix a build error and enable static builds. This lets us build libnotify on Linux via vcpkg, with optional GObject introspection.
Written for commit 21f8914. Summary will update on new commits.