Skip to content

Fix for drive array growing each time getDrives is called #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for drive array growing each time getDrives is called #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a46c0
Update package.json
nyxtom Jul 8, 2016
d6e9191
Move array variable inside function so it does not grow with each cal…
gavinaiken Feb 23, 2017
d9407b8
Merge pull request #1 from nyxtom/master
gavinaiken Feb 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/diskinfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

var exec = require('child_process').exec;
var os = require('os');
var aDrives = [];

/**
* Returns an array of drives or calls callback
Expand All @@ -18,6 +17,7 @@ var aDrives = [];
* the array of drives, set null if no callback
*/
exports.getDrives = function(callback) {
var aDrives = [];

switch (os.platform().toLowerCase()) {
case 'win32':
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Benoit Gauthier",
"name": "diskinfo",
"description": "Nodejs module to get drive information, tested on linux centos and windows vista",
"version": "0.0.3",
"version": "0.0.4",
"license": "MIT",
"main": "./lib/diskinfo.js",
"scripts": {
Expand All @@ -25,7 +25,8 @@
},
"os": [
"linux",
"win32"
"win32",
"darwin"
],
"devDependencies": {
}
Expand Down