perf(router): optimize deployment filtering in pre-call checks #15611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace O(n²) list pop pattern with O(n) set-based filtering in _pre_call_checks() to improve routing performance under high load. Changes: - Use set() instead of list for invalid_model_indices tracking - Replace reversed list.pop() loop with single-pass list comprehension - Eliminate redundant list→set conversion overhead Impact: - Hot path optimization: runs on every request through the router - ~2-5x faster filtering when many deployments fail validation - Most beneficial with 50+ deployments per model group or high invalidation rates (rate limits, context window exceeded) Technical details: Old: O(k²) where k = invalid deployments (pop shifts remaining elements) New: O(n) single pass with O(1) set membership checks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…com/BerriAI/litellm into litellm_improve_deployment
AlexsanderHamir
merged commit 87243e0
into
litellm_october_alexsander_stanging
36 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
perf(router): optimize deployment filtering in pre-call checks
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🧹 Refactoring
Changes
Test Results