[HELM][Ingress] Support custom service name and port in ingress paths #15644
+475
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Allow specifying serviceName and servicePort per path in ingress configuration. Handles both numeric and string port types for K8s versions with different backend formats.
Toninh0
force-pushed
the
helm-charts-improve-ingress
branch
from
374cc82 to
ab178f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Allow specifying custom serviceName and servicePort per path in ingress configuration.
Relevant issues
The main motivation is to make it possible to take advantage of ALB annotations such as actions , among other custom ingress routing
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
🧹 Refactoring
✅ Test
Changes
Refactored Ingress manifest's template file (deploy/charts/litellm-helm/templates/ingress.yaml) in order to handle custom
serviceNameandservicePortas part of hosts' paths configuration