Skip to content

Conversation

jwokaty
Copy link
Collaborator

@jwokaty jwokaty commented May 6, 2025

This should merged after Bioconductor/biocViews#15 as it uses the functions to generate the alias and reference dbs requested by CRAN.

@jwokaty jwokaty merged commit 56540c0 into devel Jun 4, 2025
jwokaty added a commit that referenced this pull request Jun 4, 2025
@jwokaty jwokaty mentioned this pull request Jun 4, 2025
jwokaty added a commit that referenced this pull request Jun 4, 2025
@jwokaty
Copy link
Collaborator Author

jwokaty commented Jun 4, 2025

These additional changes will be good:

diff --git a/utils/makeMetaDbs.R b/utils/makeMetaDbs.R                                                                                                                   
index ec0926a1..32fdd6c7 100644                                                                                                                                          
--- a/utils/makeMetaDbs.R                                                                                                                                                
+++ b/utils/makeMetaDbs.R                                                                                                                                                
@@ -1,6 +1,5 @@                                                                                                                                                          
-makeMetaDbs <- function(db_filepath, repos_root, meta_path) {                                                                                                           
+makeMetaDbs <- function(db_filepath, meat_path, repos_root, meta_path) {                                                                                                
                                                                                                                                                                         
-  meat_dir <- Sys.getenv("BBS_MEAT_PATH")                                                                                                                               
   prop_status <- read.dcf(db_filepath)                                                                                                                                  
                                                                                                                                                                         
   pkgs <- c()                                                                                                                                                           
@@ -18,7 +17,7 @@ makeMetaDbs <- function(db_filepath, repos_root, meta_path) {                                                                                          
     dir.create(meta_dir, recursive = TRUE)                                                                                                                              
   }                                                                                                                                                                     
                                                                                                                                                                         
-  pkg_paths <- file.path(meat_dir, pkgs)                                                                                                                                
+  pkg_paths <- file.path(meat_path, pkgs)                                                                                                                               
   for (pkg_path in pkg_paths) {                                                                                                                                         
     biocViews::build_db_from_source(pkg_path, repos_root)                                                                                                               
   }                                                                                                                                                                     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant