feat(wrapperModules.fish): init

[ormoyo]

Add wrapperModule: fish

[BirdeeHub]

Hi there!

So, first thing that comes to mind.

We ended up running into some issues when wrapping zsh that might be relevant here as well.

Basically, nixpkgs has an /etc/set-environment script

And home manager likely has things in its profile paths as well to source.

Both of those have the ability to overwrite things we provide via the wrapper.

#295 (reply in thread)

^ context for the issues we ended up running into.

Basically, we ended up generating the entire wrapper into the config file, so that we run after that gets sourced

https://github.com/BirdeeHub/nix-wrapper-modules/blob/708dd619b5096f93c55ccef25af9cae5e57d4190/wrapperModules/z/zsh/zshenv.nix

---

I am not sure if any of that is relevant for fish, but that would be the first things to test.

Depending on when this gets ran, we may or may not run into the same issues.

---

These links may or may not be useful as well, they are the relevant PRs for when the zsh wrapper was added and also for a fix that was needed for it.

There may be some useful information in there, if you do end up finding that there are similar issues here as well

#347

#355

#356

[ormoyo]

After some testing, it seems a change to an environment variable in the wrapper is kept even if it has an override in /etc/set-environment.

As for #295 (reply in thread), config.extraPackages works completly fine.

And for that, the fish arg --no-config is set, so only the wrapper's configration is used (I think the same applies to the home-manager stuff).

[BirdeeHub]

Ok I will check it out sometime this week on my system to make sure everything is good :)

Somewhat hesitant about --no-config, worried that will make it so that some things are not provided by nixos or home manager