Skip to content

Conversation

@olegabr
Copy link
Contributor

@olegabr olegabr commented Jul 10, 2022

PHP v8 support requires newer lastguest/murmurhash version

@Alfredao
Copy link

Alfredao commented Dec 4, 2022

How about merging this?

@mocapapa
Copy link

I have the same issue :(

"pleonasm/merkle-tree": "1.0.0",
"composer/semver": "^1.4.0|^3.2.0",
"lastguest/murmurhash": "v2.0.0",
"lastguest/murmurhash": "v2.1.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olegabr how do you think ^2.1.0 (they support after 2.1.0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sc0Vu I prefer the exact version here for better security.

@mxk1011
Copy link

mxk1011 commented Jun 8, 2023

Please merge this :- )

@BafS
Copy link

BafS commented Jul 3, 2023

For information we maintain a fork to be PHP 8 compatible (https://github.com/ProtonMail/bitcoin-php)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants