Skip to content

feat(sdk-coin-flrp): enhance transaction builders with addressesIndex handling #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohd-kashif merged 1 commit into from
Jan 16, 2026
Merged

feat(sdk-coin-flrp): enhance transaction builders with addressesIndex handling #7922

mohd-kashif merged 1 commit into from
Jan 16, 2026
+188 −443

Conversation

@mohd-kashif
Copy link
Contributor

@mohd-kashif mohd-kashif commented Jan 16, 2026 •
edited
Loading

  • Added logic to utilize pre-computed addressesIndex for signature ordering in AtomicTransactionBuilder.
  • Updated ImportInCTxBuilder and ImportInPTxBuilder to incorporate addressesIndex for threshold and address mapping.
  • Enhanced unit tests to verify correct handling of half-signed and unsigned transactions, ensuring proper signature counts and transaction structure preservation.

@mohd-kashif mohd-kashif marked this pull request as ready for review January 16, 2026 15:52
@mohd-kashif mohd-kashif requested a review from a team as a code owner January 16, 2026 15:52
@mohd-kashif mohd-kashif merged commit 99d219e into master Jan 16, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prithvishet2503 prithvishet2503 prithvishet2503 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohd-kashif @prithvishet2503